fix(windows): handle executable suffix separately from target identifier#140
Closed
leaked wants to merge 1 commit into
Closed
fix(windows): handle executable suffix separately from target identifier#140leaked wants to merge 1 commit into
leaked wants to merge 1 commit into
Conversation
josevalim
reviewed
Jun 16, 2026
Comment on lines
+558
to
+562
| target = | ||
| case target_for_version(version) do | ||
| "windows-x64" -> "windows-x64.exe" | ||
| other -> other | ||
| end |
Member
There was a problem hiding this comment.
Would this work as well? So we hardcode windows in fewer places?
Suggested change
| target = | |
| case target_for_version(version) do | |
| "windows-x64" -> "windows-x64.exe" | |
| other -> other | |
| end | |
| target = target_for_version(version) <> executable_suffix() |
Member
|
Thank you, fixed manually on main, released in 0.5.1! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.